Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't present a link, only javascript backed button, when offering to open in desktop / vscode. I want to open in vscode-insiders (so could alter the link if allowed) #234506

Open
tyeth opened this issue Nov 24, 2024 · 1 comment
Assignees

Comments

@tyeth
Copy link

tyeth commented Nov 24, 2024

Can't launch repo from github web editor to vscode-insiders desktop.
Recreation steps: goto a repo, press full stop / period (.), then try to use debug tab, see continue on button, use it to open in local vscode-insiders.
It only offers to open in vscode, and if that fails there is a try again button (which could be backed by a hyperlink) that attempts to open it again (a vscode: link).
Image

If that button was a hyperlink instead of a javascript monstrosity, then the user could copy the link into their clipboard and alter it (to begin vscode-insider: or whatever) before pasting again into the address bar.

Alternatively you could offer that as an option from the try again dialog, or the command palette, or as a development environment extension (one of the options is to install a new one which effectively searches extensions for @tag:continueOn )

Image

@tyeth
Copy link
Author

tyeth commented Nov 24, 2024

Or maybe you could attempt the reinvention of the visual studio version selector dialog, which gave users the choice of installed visual studio editions whenever a suitable link was invoked. You could include both visual studio code and visual studio full fat editions.

It was full of complaints, probably because it didn't offer the user an easy way to reenable the dialog after choosing don't show again, although my memory of it is foggy. Maybe there was a key combo when loading things to get it to show, but who remembers all of those... I'd suggest instead showing a brief dialog with the key combo shown clearly so a user could cancel the ongoing opening version (or at least rerun the open command and be ready the next time), or maybe show the version list with selected one and Loading in 2..1.. where the enter key immediately loads it and other keys cause it to cancel the timer. Could even show what it's loading (like cmd line arguments of the project / repo / whatever)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants