Fix logger for Melodic #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something with the bound method caused an error when running this package in Melodic. This seems to work as far as we can tell, and should work in earlier versions of ROS and Python.
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
========================================
- Coverage 90% 88.4% -1.6%
========================================
Files 1 1
Lines 150 155 +5
========================================
+ Hits 135 137 +2
- Misses 15 18 +3
Continue to review full report at Codecov.
|
|
Thanks for the contribution! There should be a fix for this in the dev branch already, would you mind checking if it works for you? |
Not exactly pretty, but it works for all occurrences in this code.
|
I'm sure that will work. Should've thought to check for other branches. Cheers! |
|
No worries, I've been a bit slack maintaining this lately and there's quite a bit sitting unmerged. Don't hesitate to raise an issue if you come across anything else :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something with the bound method caused an error when running this package in Melodic, as reported in #5 . This seems to work as far as we can tell, and should work in earlier versions of ROS and Python.
Fixes #5