Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arducam Simulator to Follow NOS3 Convention for bus tag nesting #151

Closed
msuder opened this issue Mar 21, 2023 · 2 comments
Closed

Fix arducam Simulator to Follow NOS3 Convention for bus tag nesting #151

msuder opened this issue Mar 21, 2023 · 2 comments
Assignees
Labels
Bug Something isn't working

Comments

@msuder
Copy link
Contributor

msuder commented Mar 21, 2023

Fix XML and hardware model XML parsing.

Wrong:

        <simulator>
            <name>camsim</name>
            <active>true</active>
            <library>libcam_sim.so</library>
            <hardware-model>
                <type>ARDUCAM_OV5640</type>
                <connections>
                    <connection><type>command</type><bus-name>command</bus-name><node-name>cam-command-node</node-name></connection>
                </connections>
                <!-- <stream_data>true</stream_data> -->
                <i2c>
                    <address>60</address>
                    <bus>i2c_2</bus>
                </i2c>
                <spi>
                    <bus>spi_0</bus>
                    <chip_select>0</chip_select>
                </spi>
            </hardware-model>

Right:

        <simulator>
            <name>camsim</name>
            <active>true</active>
            <library>libcam_sim.so</library>
            <hardware-model>
                <type>ARDUCAM_OV5640</type>
                <connections>
                    <connection><type>command</type><bus-name>command</bus-name><node-name>cam-command-node</node-name></connection>
                    <connection><type>spi</type>
                        <bus-name>spi_0</bus-name>
                        <chip-select>0</chip-select>
                    </connection>
                    <connection><type>i2c</type>
                        <bus-name>i2c_2</bus-name>
                        <address>60</address>
                    </connection>
                </connections>
                <!-- <stream_data>true</stream_data> -->
            </hardware-model>

@msuder
Copy link
Contributor Author

msuder commented Mar 22, 2023

Other sims that need fixed (move bus info under <connections><connection>...): generic_css_sim.

@jlucas9 jlucas9 moved this to Backlog in NOS3 Path Forward Apr 3, 2023
@jlucas9 jlucas9 mentioned this issue Apr 4, 2023
@jlucas9 jlucas9 added the Bug Something isn't working label Apr 4, 2023
@jlucas9 jlucas9 moved this from Backlog to Next Release in NOS3 Path Forward Apr 26, 2023
@jlucas9 jlucas9 added this to the 1.6.2 milestone May 10, 2023
@jlucas9
Copy link
Contributor

jlucas9 commented Jul 10, 2023

This should be resolved as part of the #164 issue

@jlucas9 jlucas9 closed this as completed Sep 14, 2023
@github-project-automation github-project-automation bot moved this from Next Release to Done in NOS3 Path Forward Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants