Allow editing of notes in inspector #1280
Comments
|
@charlesh88 to do some UI sketches so we can make this into a |
|
Here's a UI sketch of how Notes could be extended into the Inspector in both browse and edit modes. There may be a case for allowing Notes to always be editable - that is, during browse mode as well. That said, starting with Notes editable via the Inspector only during Edit mode (and in the Properties dialog as currently implemented) is IMO the best way to initially implement this. |
|
If you wanted to go ahead and assign me to this, I have a working solution to this. I am new to MVC/angular and contributing to open source. I am modifying it to make sure I think it is structured correctly. Thanks. |
|
@evanohara Thanks for looking into this. I'm not able to assign issues to folks outside the NASA organization, but consider it assigned 😄 |
|
Just wanted to give you an update. I have a solution that I am happy with. I still have a little work ahead of me with the unit tests. This would also be my first real leap into designing unit tests but I'm having fun. Is there a better forum to ask general things about the project or to get clarification? Thanks! |
|
You can always email us at [email protected] and we usually respond pretty quick-- best between 8am and 6pm but usually pretty good for discussion. Otherwise, feeel free to leave comments here and we can respond publicly. |
|
@evanohara Glad to hear you're having fun! In preparation for preparing a PR it's worth taking a look at the page on contributing on our website. It includes links to useful information about our process, and most importantly a link to the Contributor License Agreement which we will need signed before we can merge any of your code. Once again, thanks for taking the time to help us out! |
Separated the notes property into a new region in order to allow it to be hidden when in edit mode. An editable template will take its place in edit mode. nasa#1280
Separated notes from object-properties to allow it to be hidden in edit mode. A new region will be added for the editable version. nasa#1280
Created a new edit-notes.html and a corresponding EditNotesController to be used to replace the notes region when in edit mode. nasa#1280
Created the EditNotesService.js to allow for communication between SaveAction and EditNotesController. nasa#1280
EditNotesController now keeps the EditNotesService up to date with any input the user enters into the textbox. nasa#1280
SaveAction and SaveAndStopEditingAction now depend on EditNotesService to allow the saving of the new notes property when these actions are clicked. nasa#1280
The bundle has been updated to reflect the new dependencies. nasa#1280
SaveAction and SaveAndStopEditingAction simply needed dependencies for EditNotesService. InspectorRegion now expects 3 regions instead of 1. nasa#1280
Simple test cases added for new classes. nasa#1280
Fixes #1280 Added margin-bottom to .l-inspector-part; Added class to edit-notes.html;
|
Sure! No problem. I sent the CLA to Kim. I've had some time to think about other ways to solve this. I mostly didn't like adding dependencies to any existing code. It seems if possible my contribution should stand alone. One solution would be to add a separate edit/save button just for the notes. I'll wait to hear what you think though. Thanks! |
The notes field is hard to edit for objects that use edit mode. For instance, a display layout will show notes in the inspector, but editing that display layout does not give you a way to edit the notes. Instead you have to right click -> edit properties. It would be nice to make it easier to edit notes.
The text was updated successfully, but these errors were encountered: