Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot scroll in layouts and fixed position view #232

Closed
larkin opened this issue Nov 2, 2015 · 6 comments
Closed

Cannot scroll in layouts and fixed position view #232

larkin opened this issue Nov 2, 2015 · 6 comments
Assignees
Milestone

Comments

@larkin
Copy link
Contributor

larkin commented Nov 2, 2015

It seems that as of the lastest build, it is not possible to scroll in a layout view, even if content exists off screen. The scroll bar is not visible, and the view does not response to the scroll wheel or other methods of scrolling.

scrolling views and item views still scroll properly.

@larkin larkin added this to the Ballard milestone Nov 2, 2015
@larkin
Copy link
Contributor Author

larkin commented Nov 2, 2015

Quick checking shows that this was working properly before the resolution for #195 was merged. Sending to @VWoeltjen for investigation.

@VWoeltjen
Copy link
Contributor

Looking into this - this occurs because the relevant styles reference ng-include, which is no longer used/useful after changes for #195.

Changing .object-holder > ng-include to mct-representation.object-holder in CSS files for themes appears to address the issue. Reassigning to Charles to complete the fix in the original SASS

@VWoeltjen VWoeltjen assigned charlesh88 and unassigned VWoeltjen Nov 2, 2015
@VWoeltjen
Copy link
Contributor

@charlesh88 - a little bit more background on this. #195 was solved by:

  • Swapping out mct-representation and mct-include elements with comments when there is nothing to show
  • Instead of using ng-include to load the inner template, template contents are loaded directly into mct-representation. (This is the change which triggered this issue.) This allows for detecting cases where a template can not be loaded (which ng-include doesn't support)

@charlesh88
Copy link
Contributor

Working on this now. Will be open232, branched from master.

@charlesh88
Copy link
Contributor

Pull request filed as #236

@RCarvalhoNASA
Copy link

Testathon 20151123: Verified this is working now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants