Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewProvider show replaces viewContainer provided by ObjectView #2652

Open
shefalijoshi opened this issue Jan 30, 2020 · 0 comments
Open

ViewProvider show replaces viewContainer provided by ObjectView #2652

shefalijoshi opened this issue Jan 30, 2020 · 0 comments
Labels
bug:retest Retest without a specific milestone severity:trivial type:bug

Comments

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Jan 30, 2020

As of Vue 2.x:

The provided element merely serves as a mounting point. Unlike in Vue 1.x, the mounted element will be replaced with Vue-generated DOM in all cases. It is therefore not recommended to mount the root instance to or .

https://vuejs.org/v2/api/#el

This means the viewContainer we are passing to the show methods of our viewProviders are being replaced by the view's contents.
The css classes 'c-object-view' and 'u-contents' applied to the viewContainer are no longer available to us.
See: https://github.com/nasa/openmct/blob/master/src/ui/components/ObjectView.vue#L92

@charlesh88 Unsure what those classes were meant to do - please advise.

Note: This likely isn't breaking openMCT is any serious way yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:retest Retest without a specific milestone severity:trivial type:bug
Projects
None yet
Development

No branches or pull requests

2 participants