Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Search will fail to index items using the proper provider #3399

Open
jvigliotta opened this issue Sep 24, 2020 · 3 comments · Fixed by #3400
Open

[Search] Search will fail to index items using the proper provider #3399

jvigliotta opened this issue Sep 24, 2020 · 3 comments · Fixed by #3400
Assignees

Comments

@jvigliotta
Copy link
Contributor

Need to switch from modelService to objectService in GenericSearchProvider to handle cases where the wrong provider was being used.

Testing

  • include My Items plugin
  • use CouchDB persistence
  • Modify the My Items folder name and save (should then save to couch)
  • Refresh and observe that the My Items folder (with the changed name) is being indexed for search
@deeptailor
Copy link
Contributor

Verified Fixed - but ran into another issue where searched dictionary items dont have the correct object path, which causes issues of navigating, and context menus.

@davetsay
Copy link
Contributor

davetsay commented Oct 5, 2020

Found issue

Steps

  1. Changed Shared Items folder name to My Items.
  2. Searched for 'shared'

My Items came up in search results. Also, changing folder name in tree afterwards did not stick upon renavigation.

image

@charlesh88
Copy link
Contributor

charlesh88 commented Oct 5, 2020

Verified partially fixed Testathon 10-05-20, but with another problem:

  1. Follow test steps as outlined above.
  2. For the item that had its name changed, change it back. Or, rename an existing object to remove a part of its name.
  3. Search for the original name for the object who's name was changed in step 2. Note that it will appear in search results, but shouldn't.

@charlesh88 charlesh88 reopened this Oct 5, 2020
@davetsay davetsay reopened this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants