[Search] SearchProvider and Tree Search enhancements/fixes #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeptailor
suggested changes
Sep 24, 2020
platform/search/bundle.js
Outdated
| @@ -109,7 +109,8 @@ define([ | |||
| "topic", | |||
| "GENERIC_SEARCH_ROOTS", | |||
| "USE_LEGACY_INDEXER", | |||
| "openmct" | |||
| "openmct", | |||
| "objectService" | |||
There was a problem hiding this comment.
lets add this in place of modelService, since we are replacing it
|
@jvigliotta - were there any legacy tests that need updating? We should not be adding tests to legacy code but we should update them if needed |
Reviewer ChecklistChanges appear to address issue? Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the objectService to the GenericSearchProvider to handle cases where the wrong provider was being used to get the object/model. Also small refactor to the navigation tree to handle search more appropriately (searching indicator, clearing children, etc).
closes #3399
Author Checklist
Changes address original issue? Yes
Unit tests included and/or updated with changes? N/A Legacy
Command line build passes? Yes
Changes have been smoke-tested? Yes
Testing instructions included? Yes