Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Display Layout] cannot save styles for imagery providing telemetry objects from dictionaries #3472

Open
davetsay opened this issue Oct 26, 2020 · 5 comments
Assignees

Comments

@davetsay
Copy link
Contributor

Overview

Dictionary based telemetry endpoints that provide imagery are not able to save styles to. Alpha numeric endpoint from the same dictionary are working as expected. Styles are being (attempted to be) saved on the objects themselves rather than the layouts. This results in an inconsistent state as these style changes are not being persisted to the objects.

Expected Behavior

Styles applied to these telemetry items should be saved on the layout in which they were styled.

Steps to Reproduce

  1. Create a display layout
  2. From a dictionary, drag in a telemetry endpoint that provides imagery (may need to be on a server deployment)
  3. Conditionally style the telemetry endpoint in the layout and save layout
  4. Observe notification of persistence error
  5. Optionally add the telemetry endpoint to a different layout and see that same styles are applied (when they shouldn't be)
  6. Refresh browser
  7. Observe that styles on telemetry endpoint in layout are now gone
@akhenry
Copy link
Contributor

akhenry commented Nov 6, 2020

Unable to verify, styles are not being applied to image telemetry in layouts.

@charlesh88
Copy link
Contributor

charlesh88 commented Nov 6, 2020

Verified NOT fixed Testathon 11-06-20: can't apply styles to a real or Example Imagery object in a layout.

@charlesh88 charlesh88 reopened this Nov 6, 2020
@davetsay
Copy link
Contributor Author

davetsay commented Nov 6, 2020

@shefalijoshi the issue i think is that we changed wheres styles are persisted for this object type but we didn't make the same change to getObjectsAndItemsFromSelection so the persisted styles are not being rendered.

@unlikelyzero
Copy link
Collaborator

Still a bug and not fixed. Potential for MMGIS styling concerns to be filed separately

@unlikelyzero
Copy link
Collaborator

@davetsay will take a look at this. We should update the severity of the issue and understand what can be done in this specific Display Layout case and the general case.

@unlikelyzero unlikelyzero added the needs:test instructions Missing testing notes label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants