Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update PR Template to remove the colon from Closes #4785

Merged
merged 1 commit into from
Jan 26, 2022
Merged

[CI] Update PR Template to remove the colon from Closes #4785

merged 1 commit into from
Jan 26, 2022

Conversation

unlikelyzero
Copy link
Collaborator

Closes: #4154

Describe your changes:

Updating the template while using the old template with the colon to verify whether this is a bug with discovery,linking, or closure of issues with the github api.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #4785 (00f6cb3) into master (159457a) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4785      +/-   ##
==========================================
- Coverage   56.90%   56.87%   -0.04%     
==========================================
  Files         722      722              
  Lines       22806    22806              
  Branches     1655     1655              
==========================================
- Hits        12978    12971       -7     
- Misses       9410     9417       +7     
  Partials      418      418
Impacted Files Coverage Δ
src/api/objects/ObjectAPI.js 91.71% <0.00%> (-2.21%) ⬇️
src/plugins/imagery/components/ImageryView.vue 38.00% <0.00%> (-2.19%) ⬇️
...c/plugins/persistence/couch/CouchObjectProvider.js 82.22% <0.00%> (+0.44%) ⬆️
src/plugins/imagery/components/ImageryTimeView.vue 72.41% <0.00%> (+0.57%) ⬆️
src/plugins/timeConductor/ConductorHistory.vue 51.06% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159457a...00f6cb3. Read the comment docs.

@unlikelyzero unlikelyzero enabled auto-merge (squash) January 26, 2022 19:33
@unlikelyzero unlikelyzero merged commit cdee5e8 into master Jan 26, 2022
@unlikelyzero unlikelyzero deleted the no-colon branch January 26, 2022 19:34
@unlikelyzero unlikelyzero mentioned this pull request Jan 26, 2022
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhenry akhenry akhenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to capture notebook snapshot in folder view using Firefox
2 participants
@unlikelyzero @akhenry