Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Layout snapping grid not displaying while editing #4299

Closed
1 of 5 tasks
charlesh88 opened this issue Oct 6, 2021 · 4 comments · Fixed by #4300
Closed
1 of 5 tasks

Display Layout snapping grid not displaying while editing #4299

charlesh88 opened this issue Oct 6, 2021 · 4 comments · Fixed by #4300
Labels
type:bug

Comments

@charlesh88
Copy link
Contributor

Summary

Title says it all. Appears as though a recent change moved the target for the s-selected attribute from l-shell__main-container to its immediate child, breaking the CSS used to display the grid holder.

Expected vs Current Behavior

Snapping grid should display (if enabled) while editing.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Edit a Display Layout.
  2. Make sure snapping grid is enabled.
  3. Observe: no grid is displayed.

Environment

  • Open MCT Version: 1.7.8
  • Deployment Type: /stable, local
  • OS:
  • Browser:

Additional Information

image
@charlesh88 charlesh88 self-assigned this Oct 6, 2021
@charlesh88
Copy link
Contributor Author

charlesh88 commented Oct 6, 2021 •
edited
Loading

Testing Notes

Screen Shot 2021-10-06 at 4 10 26 PM

  1. Edit a Display Layout.
  2. Make sure snapping grid is enabled (purple arrow as above).
  3. Observe: grid should be displayed (green arrow as above).

charlesh88 added a commit that referenced this issue Oct 6, 2021
@charlesh88
Fix #4299
776fb87 
- Modded CSS selector to target child of `__main-container` element;
@charlesh88 charlesh88 mentioned this issue Oct 6, 2021
Merged
8 tasks
@akhenry
Copy link
Contributor

akhenry commented Oct 11, 2021

Is this the same issue as #4207 ?

nikhilmandlik pushed a commit that referenced this issue Oct 13, 2021
@charlesh88
Fix #4299 (#4300)
b64ee10
@charlesh88
Copy link
Contributor Author

@akhenry No, this is the complete absence of the grid. I've added comments to #4207.

@charlesh88 charlesh88 mentioned this issue Oct 26, 2021
Closed
5 tasks
@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 10/27/21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4299 nasa/openmct
5 participants
@charlesh88 @nikhilmandlik @khalidadil @akhenry @unlikelyzero