Skip to content

Plot Y axis visual tweaks #6184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Plot Y axis visual tweaks #6184

wants to merge 1 commit into from

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented Jan 25, 2023 •
edited by davetsay
Loading

Closes #6173

  • Better CSS classing for gl-plot-y__axis-visibility.
  • Hide visibility control when editing.
  • Theme colors modified to normalize plot border colors.

WIP! In draft until item 2 in the issue is resolved.

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@charlesh88
Closes #6173
5052054 
- Better CSS classing for `gl-plot-y__axis-visibility`.
- Hide visibility control when editing.
- Theme colors modified to normalize plot border colors.
@codecov
Copy link

codecov bot commented Jan 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.86%. Comparing base (ca737d8) to head (5052054).
Report is 608 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6184   +/-   ##
=======================================
  Coverage   54.86%   54.86%           
=======================================
  Files         607      607           
  Lines       25940    25940           
  Branches     2349     2349           
=======================================
+ Hits        14232    14233    +1     
+ Misses      11046    11045    -1     
  Partials      662      662
Flag Coverage Δ *Carryforward flag
e2e-ci 39.49% <ø> (ø) Carriedforward from ca737d8
e2e-full 51.23% <ø> (ø) Carriedforward from ca737d8
e2e-stable 53.60% <ø> (+0.06%) ⬆️
unit 49.48% <100.00%> (ø) Carriedforward from ca737d8

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/plugins/plot/axis/YAxis.vue 64.86% <100.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca737d8...5052054. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davetsay davetsay requested a review from shefalijoshi January 30, 2023 21:51
@davetsay davetsay added this to the Target:2.1.6 milestone Jan 30, 2023
@davetsay
Copy link
Contributor

davetsay commented Jan 30, 2023 •
edited
Loading

@shefalijoshi , @charlesh88 needs your help on this bit from the issue,
Not enough room between axis 2 line and axis 1 value swatches.

@davetsay davetsay modified the milestones: Target:2.1.6, Target:2.2.0 Jan 30, 2023
@davetsay davetsay requested review from ozyx and removed request for shefalijoshi January 30, 2023 21:53
@charlesh88
Copy link
Contributor Author

2/2/2023: still waiting on help with margin, item 2 in #6173.

@shefalijoshi shefalijoshi self-requested a review February 27, 2023 21:57
@charlesh88
Copy link
Contributor Author

Still waiting for help with margins, see issue item 2 for notes.

@unlikelyzero unlikelyzero removed this from the Target:2.2.0 milestone Mar 18, 2023
shefalijoshi
shefalijoshi reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlesh88
To changed the space between the 1st axis swatch and the 2nd axis line, please set this to some negative value:
https://github.com/nasa/openmct/blob/plot-tweaks-6173/src/plugins/plot/axis/YAxis.vue#L150

@shefalijoshi
Copy link
Contributor

@charlesh88 Please have a look at this change as well: #6264
It addresses wrapping of the swatch, hide/show icon and gear icons when you reduce vertical height of the plot.

@akhenry
Copy link
Contributor

akhenry commented Mar 26, 2025

@shefalijoshi @charlesh88 Closing this PR. If the changes in this branch are needed please open a new PR

@akhenry akhenry closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shefalijoshi shefalijoshi shefalijoshi left review comments

@ozyx ozyx Awaiting requested review from ozyx

Assignees

@shefalijoshi shefalijoshi

@ozyx ozyx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plot Y axis visual tweaks needed
6 participants
@charlesh88 @davetsay @shefalijoshi @akhenry @ozyx @unlikelyzero