Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support in Gauge for bar and needle display styles #5083

Closed
wants to merge 72 commits into from

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented Apr 18, 2022

Describe your changes:

Closes #6397.

Simplifies the code and UI to allow a user to apply either a needle or bar display style to all Gauge types: dial, vertical and horizontal meters.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

charlesh88 and others added 30 commits March 4, 2022 14:18
- Copied WIP from maelstrom2-core branch;
- Initial integration with current Open MCT codebase;
- Added needle display style;
- Tweaked form wording;
- WIP!
- Added vertical and horizontal meter gauge types;
- WIP!
- Major additions of vertical and horizontal meter gauge types;
- Min and max range values now display based on properties settings;
- Better color definitions, moving towards theme-based color vars;
- Animation transition now applied to gauge value elements transforms;
- Better approach to clipping high and low values/ranges in meter;
- Tweaks to properties form text;
- Enhanced GAUGE_TYPES const for better human-readable names;
- WIP: turn off transition for dial to avoid delay "flash" problem;
- Remove rotation angle clipping from needle dial gauge;
- Reinstate transition for needle dial only;
- Fix typo in props form;
- WIP!
- Significant work: added lower limit to dial and meter;
- Added limitLow, refactored limit to limitHigh;
- Improved valToPercentMeter method;
- Handle case when high or low limit isn't defined;
- Current value implemented as size-relative SVG text in dial and meter;
- Code cleanups;
- TODO: cleanup and migrate colors to themes;
- Merging Nikhil's latest, resolve conflicts;
- TODO: clip dial display when values are outside set min/max;
- Added check to suppress display of dial needle;
- Moved filled dial display check in code;
- Code cleanup;
- Color refinement;
- Code cleanup;
- Properties form CSS cleanups and text tweaks;
- Added gauge type `meter-vertical-inverted`;
- CSS tightened up;
jvigliotta and others added 21 commits March 22, 2022 20:06
- Separate gauge type (dial, meter, etc.) from graphic value display style (bar, needle);
- Gauge types reduced to 4;
- Add gaugeDisplayStyle property for bar and needle;
- SCSS cleanups for clarity and simplicity;
- Separate gauge type (dial, meter, etc.) from graphic value display style (bar, needle);
- Gauge types reduced to 4;
- Add gaugeDisplayStyle property for bar and needle;
- SCSS cleanups for clarity and simplicity;
@davetsay
Copy link
Contributor

@charlesh88 , to review what changes need to be preserved from this PR, and potentially create a new issue and close this PR out.

@charlesh88
Copy link
Contributor Author

Closing for now. Notes in #6397.

@charlesh88 charlesh88 closed this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better support in Gauge for bar and needle display styles
5 participants