-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better support in Gauge for bar and needle display styles #5083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copied WIP from maelstrom2-core branch; - Initial integration with current Open MCT codebase;
- Added needle display style; - Tweaked form wording;
- WIP! - Added vertical and horizontal meter gauge types;
- WIP! - Major additions of vertical and horizontal meter gauge types; - Min and max range values now display based on properties settings; - Better color definitions, moving towards theme-based color vars; - Animation transition now applied to gauge value elements transforms;
- Better approach to clipping high and low values/ranges in meter;
- Tweaks to properties form text; - Enhanced GAUGE_TYPES const for better human-readable names;
- WIP: turn off transition for dial to avoid delay "flash" problem;
- Remove rotation angle clipping from needle dial gauge; - Reinstate transition for needle dial only; - Fix typo in props form;
- WIP! - Significant work: added lower limit to dial and meter; - Added limitLow, refactored limit to limitHigh; - Improved valToPercentMeter method;
- Handle case when high or low limit isn't defined;
- Current value implemented as size-relative SVG text in dial and meter; - Code cleanups; - TODO: cleanup and migrate colors to themes;
- Merging Nikhil's latest, resolve conflicts; - TODO: clip dial display when values are outside set min/max;
- Added check to suppress display of dial needle; - Moved filled dial display check in code; - Code cleanup;
- Color refinement; - Code cleanup;
- Properties form CSS cleanups and text tweaks;
…ime conductors start end values.
- Added gauge type `meter-vertical-inverted`; - CSS tightened up;
…, use latest added telemetry point.
- Separate gauge type (dial, meter, etc.) from graphic value display style (bar, needle); - Gauge types reduced to 4; - Add gaugeDisplayStyle property for bar and needle; - SCSS cleanups for clarity and simplicity;
- Separate gauge type (dial, meter, etc.) from graphic value display style (bar, needle); - Gauge types reduced to 4; - Add gaugeDisplayStyle property for bar and needle; - SCSS cleanups for clarity and simplicity;
15 tasks
@charlesh88 , to review what changes need to be preserved from this PR, and potentially create a new issue and close this PR out. |
Closing for now. Notes in #6397. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Closes #6397.
Simplifies the code and UI to allow a user to apply either a needle or bar display style to all Gauge types: dial, vertical and horizontal meters.
All Submissions:
Author Checklist
Reviewer Checklist