Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout hidden frame controls prevent usage of visible layout frame controls #6379

Closed
1 of 7 tasks
charlesh88 opened this issue Feb 28, 2023 · 3 comments · Fixed by #6486
Closed
1 of 7 tasks

Layout hidden frame controls prevent usage of visible layout frame controls #6379

charlesh88 opened this issue Feb 28, 2023 · 3 comments · Fixed by #6486
Labels
severity:critical type:bug
Milestone
Target:2.2.1

Comments

@charlesh88
Copy link
Contributor

Summary

When layouts include a nested layout with its frame hidden, the popup controls for the hidden layout's frame can prevent usage of visible "more options" controls for nested elements. This is particularly problematic with Flexible Layouts where nested element's frames can easily occupy the same space. Seen during SIM-2 today.

Expected vs Current Behavior

When a layout is nested and its frame has been hidden, then completely hide its popup "more options" buttons.

Steps to Reproduce

  1. Make a new Flexible Layout. Drag a plot, table or imagery view(s) into it. Save it.
  2. Make a new Flexible Layout, and drag the first layout into it. Use columns layout and place that element in the right hand column. Save it.
  3. In browse mode, mouse over the 3 dot menu for the layout from step 2. Note that the more options menu for the hidden frame appears (blue background in Espresso theme), covering the button options for view in the upper right.
  4. Click "View Large" on the hidden frame options holder, note that the hidden frame is shown in large view, not the individual view the user expected.

Environment

  • Open MCT Version: 2.1.4
  • Deployment Type:
  • OS: all
  • Browser: all

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

Nested Flex Layout with hidden frame, note structure in tree at left.
Screen Shot 2023-02-28 at 12 45 18 PM

Nested more options menu appearing
Screen Shot 2023-02-28 at 12 45 14 PM
@charlesh88 charlesh88 self-assigned this Feb 28, 2023
@charlesh88
Copy link
Contributor Author

Testing Notes

Test 6379.json.zip

  1. Import the attached Display Layout; this will give you a Display Layout that holds a Flexible Layout, which in turn holds an Example Imagery.

  2. Nav to the imported layout named "Display Layout holds Flex Layout". You should see something similar to the reference below.
    Screen Shot 2023-03-21 at 1 47 35 PM

  3. Edit the layout: first set the Example Imagery to hide its frame. Exit edit and confirm that hovering over the imagery displays its frame header controls (blue buttons in upper right).
    Screen Shot 2023-03-21 at 1 48 33 PM

  4. Edit the layout again: now set the "Flexible Layout holds Imagery" element to hide its frame. Exit edit and confirm that hovering over the imagery displays its frame header controls as before, and that clicking the View Large button in the hover controls displays a large view of the Imagery, NOT the Flexible Layout.
    Screen Shot 2023-03-21 at 1 49 38 PM

charlesh88 added a commit that referenced this issue Mar 21, 2023
@charlesh88
Closes #6379
1f828f8 
- Hide nested frame header buttons for Flexible Layouts as well as Display Layouts.
charlesh88 added a commit that referenced this issue Mar 21, 2023
@charlesh88
Closes #6379
dd729a5 
- Adjust z-index of frame control header buttons.
@charlesh88 charlesh88 mentioned this issue Mar 21, 2023
Merged
15 tasks
@ozyx ozyx added this to the Target:2.2.1 milestone Mar 21, 2023
@ozyx
Copy link
Contributor

ozyx commented Apr 17, 2023

Verified fixed -- Testathon 4-17-23

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 04/17/23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:critical type:bug
Projects
None yet
Milestone
Target:2.2.1
Development

Successfully merging a pull request may close this issue.

Hide Flexible Layout header buttons when frame is hidden nasa/openmct
4 participants
@charlesh88 @khalidadil @shefalijoshi @ozyx