Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need relative links for legacy code pulling openmct in as a dependency #6517

Closed
7 tasks
davetsay opened this issue Mar 27, 2023 · 2 comments · Fixed by #6518
Closed
7 tasks

Need relative links for legacy code pulling openmct in as a dependency #6517

davetsay opened this issue Mar 27, 2023 · 2 comments · Fixed by #6518
Labels
type:bug
Milestone
Target:2.2.1

Comments

@davetsay
Copy link
Contributor

davetsay commented Mar 27, 2023 •
edited
Loading

Summary

webpack aliased links are breaking code

Expected vs Current Behavior

npm should build

Testing Instructions

  1. see testing instructions and perform for ONLY telemetry table component here, [Staleness] Functionality in telemetry component views and API #6109

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@davetsay davetsay mentioned this issue Mar 27, 2023
Merged
15 tasks
@davetsay davetsay self-assigned this Mar 27, 2023
@unlikelyzero unlikelyzero added this to the Target:2.2.1 milestone Mar 30, 2023
@unlikelyzero unlikelyzero added needs:info Needs follow up or investigation needs:test instructions Missing testing notes labels Apr 17, 2023
@unlikelyzero
Copy link
Collaborator

@davetsay can you provide some more context? We can make additional changes to prevent this relative import in the future, but have been using relative imports for years

@unlikelyzero
Copy link
Collaborator

Verified as fixed and a follow up is here: #6610

@unlikelyzero unlikelyzero removed needs:info Needs follow up or investigation unverified needs:test instructions Missing testing notes labels Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
Target:2.2.1
Development

Successfully merging a pull request may close this issue.

use relative path nasa/openmct
3 participants
@davetsay @shefalijoshi @unlikelyzero