Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Styling] Only text color is inherited in flex layout styling #7337

Open
2 of 7 tasks
unlikelyzero opened this issue Jan 2, 2024 · 1 comment
Open
2 of 7 tasks

[Styling] Only text color is inherited in flex layout styling #7337

unlikelyzero opened this issue Jan 2, 2024 · 1 comment

Comments

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Jan 2, 2024

Summary

Only text color is inherited in flex layout styling. That is to say that once you create a modification to flex layout styling, child components do not inherit border and background color. This isn't totally explored and there could be other implications.

Expected vs Current Behavior

I would expect that all style properties are inherited. Only textcolor is inherited.

Steps to Reproduce

  1. Create a flex layout with a stacked plot within it
  2. Edit the flex layout styling for border, backgroundcolor, and text
  3. Inspect the stacked plot and note that only the textcolor is applied.

Environment

  • Open MCT Version: 3.3.0

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

Grep the test e2e codebase for more

@khalidadil
Copy link
Contributor

khalidadil commented Jan 19, 2024

@unlikelyzero The border and background color applied to a flex layout should be visible on the flex layout itself. The background color should be visible behind a child of the flex layout if that child doesn't have its own background color. Does that sound right @charlesh88? I think otherwise this would be different from how display layouts work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants