Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Document issues with Percy #7549

Open
2 of 3 tasks
unlikelyzero opened this issue Mar 5, 2024 · 0 comments
Open
2 of 3 tasks

[e2e] Document issues with Percy #7549

unlikelyzero opened this issue Mar 5, 2024 · 0 comments
Labels
type:maintenance tests, chores, or project maintenance

Comments

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Mar 5, 2024

Summary

As we're nearing another release, we need to document some of the known issues with Percy so that folks know what to ignore.

  • Icons do not load randomly.
Screenshot 2024-03-04 at 5 48 33 PM

I believe the answer lies in the percy debug statements

[percy:core:discovery] Handling request: http://localhost:8080/ (2ms)
[percy:core:discovery] - Serving root resource (0ms)
[percy:core:discovery] Handling request: http://localhost:8080/dist/espressoTheme.css (15ms)
[percy:core:discovery] - Resource cache hit (0ms)
[percy:core:page] Page navigated (65ms)
[percy:core:discovery] Wait for 100ms idle (0ms)
[percy:core:discovery] Handling request: http://localhost:8080/dist/images/logo-openmct.svg (38ms)
[percy:core:discovery] - Resource cache hit (0ms)
[percy:core:discovery] Handling request: http://localhost:8080/dist/fonts/Open-MCT-Symbols-16px.woff (1ms)
[percy:core:discovery] - Resource cache hit (0ms)

The above shows that the fonts are loaded separately from the rendered dom in playwright. The fix would be to add some sort of time delay to the snapshot.

  • Header values shift slightly.
Screenshot 2024-06-25 at 5 20 45 AM This is likely due to https://github.com//issues/6819 Screenshot 2024-09-25 at 10 45 10 AM
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

No branches or pull requests

1 participant