Improve telemetry table performance #7268

akhenry · 2023-12-01T21:27:23Z

Is your feature request related to a problem? Please describe.
Telemetry Tables use far too much CPU and memory, even with a single telemetry point at 10Hz.

eg. Create a 10 Hz SWG and drop it into a telemetry table. Open Chrome task manager and observe that CPU usage is 100+% and memory usage is over 500MB.

Describe the solution you'd like
I think that a 70% reduction in CPU utilization and at least 50% reduction in memory usage is achievable.

Tables should be limited to a fixed number of rows (Let's make it configurable, but 50 is probably a reasonable default). Rows beyond this can be accessed via paging. A fixed height should remove costly reflows, and limiting tables to 50 rows (ie. 50 telemetry values) should radically reduce memory usage.
Throttle table updates to 1Hz. when new data arrive, or when time bounds change batch the changes and only update the table once per second.
De-reactify table rows. Right now they are Vue 3 proxy objects and this is costly. Right now rows are being made reactive by being passed as a property to TelemetryTableRow. There's no need for this, rowIndex should be all that we need to trigger reactivity.

Throttle table updates, de-reactify rows (2, 3) PR: Table CPU Performance Improvements #7392
Table performance mode (1) PR: Table performance paging #7399

The text was updated successfully, but these errors were encountered:

charlesh88 · 2024-01-04T23:21:16Z

Solution notes as of January 2024:
"Performance" Mode

Table is constrained to 50 rows and will display the latest values (for all constituent endpoints in the table's composition) within that context based on current Time Conductor settings.
- In realtime mode, rows will be continually updated in the same fashion as current to display the most recent 50 values.
- Fixed-time mode will show the latest 50 values based on the current Time Conductor bounds.
Each endpoint in the table gets a request sent for 50 values, regardless of number of endpoints included in the table's composition. This means that although there will be extra values in Telemetry Collections (one per TC per endpoint), but will still provide significant performance improvements.
Filtering may still be possible within the 50 row limit (still working on how that will function).
- @charlesh88 says: let's talk about this.
"Export Table Data" from the Telemetry Table's action menu will inject a new confirmation overlay dialog that will inform the user that a new data request for all telemetry values for all endpoints will be made and that there may be some time involved. Clicking "Ok" dismisses the dialog and then proceeds with a re-query, with the subsequent download event being sent to the browser after the re-query is complete.
This mode is the new default, and the UI will make a new button available at the current "rows count" element at the table view's bottom that will allow the user to toggle the view into "Unlimited" mode. See screenshot below.
- This setting should at least persist while the Telemetry Table is in view, allowing the user to toggle the mode and then refresh again if needed without having to re-toggle.

Unlimited Mode

Current functionality.
When switched to from "Performance" mode, a re-request for all telemetry will be made, as in current functionality.
Export Table Data will work as current, and should not display the confirmation dialog referenced above as no new re-query should be needed.

jvigliotta · 2024-01-23T21:32:01Z

Testing

CPU Performance

Not super sure the best way to test this, but here goes
Create a table with a high frequency end point (if possible in a previous version and this version)
Open Chrome's Task Manager and compare memory usage between the two
Verify that Memory usage is significantly better

Memory/Paging/Mode Performance

Make sure you can switch between modes in the bottom right of the footer
- should show (configured/default:50) row limit in performance mode
- should show however many in unlimited mod
in fixed time, it should just be the set number of rows in performance mode
in realtime, it should be a rolling window of the set number of rows
remove an item that was taking up more rows (higher frequency endpoints crowd out lower ones) and verify that items that were pushed out before are now showing
when switching from performance to unlimited mode, verify that network requests are made for the endpoints
in "unlimited" mode, Export to Table Data (should be like normal)
in "performance" mode, Export to Table Data (should get a warning), you can cancel and stay in performance, or accept and verify that the endpoints are loaded before the CSV is exported
in Chrome's Task Manager, compare Memory usage to an older version of the same table (or complex display with many tables) in both realtime and fixed time modes

Also

#7147 with row number always visible

- Layout and style sanding and polishing. - Added title to button. - More direct button labeling.

Partially closes #7147 - Removed footer hover behavior: table footer now always visible. - Tweaks to style, margin etc. to make footer more compact.

* dereactifying the row before passing it to the commponent * debouncin * i mean... throttle * initial * UI functionality, switching between modes, prevention of export in performance mode, respect size option in swgs * added limit maintenance in table row collectins, autoscroll respecting sort order * updating the logic to work correctly :) * added handling for overflow rows, this way if an object is removed, we can go back to the most recent rows for all remaining items and repopulate the table if necessary * removing debug row numbers * Closes #7268 - Layout and style sanding and polishing. - Added title to button. - More direct button labeling. * Closes #7268 Partially closes #7147 - Removed footer hover behavior: table footer now always visible. - Tweaks to style, margin etc. to make footer more compact. * moved row limiting out of table row collections and into telemetry collections, table row collections will only limit what they return in getRows, handling sorting when in different modes * have swgs return enough data to fill the requested bounds * support minmax in swgs * using undefined for more clarity * clearing up boolean typo * Address lint fixes * removing autoscroll for descending, it is not necessary * update snapshots * lint --------- Co-authored-by: Charles Hacskaylo <[email protected]> Co-authored-by: John Hill <[email protected]>

rukmini-bose · 2024-02-08T22:48:42Z

Testathon 2/8/2024

Issues regarding "Export Table Data": When in performance mode, we DO get the confirmation dialog that switches us to Unlimited mode, but the CSV file that gets exported is empty. However, if you export while in Unlimited mode, the behavior is correct and the CSV file is populated with data.

charlesh88 · 2024-02-08T22:53:28Z

Testathon 2024-02-08: verified NOT fixed, has multiple issues:

Mode Select: (yellow arrow): need to bring language in line with button language (Latest 50/Show All). See notes below.
Performance Mode Row Limit (green arrow): this should be a number input, not a toggle.

We should change the UI like this:

In the Properties dialog and Inspector:
- Telemetry Mode > Data Mode
- New "Data Mode" select has "Limited (Performance) Mode" | "Unlimited Mode"
- Persist Telemetry Mode Changes > Persist Data Mode Changes
- Performance Mode Row Limit > Limited Data Mode Row Limit
In the table's controls (at table bottom):
- (When in Limited mode): LATEST <#> ROWS [ SHOW UNLIMITED ]
- (When in Unlimited mode): <#> ROWS [ SHOW LIMITED ]

jvigliotta · 2024-02-28T00:43:02Z

More Testing!

Verify changes from: Improve telemetry table performance #7268 (comment) and Improve telemetry table performance #7268 (comment) have been applied
Make changes in edit properties (Persist mode change, update Data Mode, Row Limit)
- For Data Mode, make sure the table reloads in the appropriate mode
- For Row Limit, (if in Limited Mode) make sure the table refreshes to the new row limit
- For Persist Mode Change, once set, change the mode to the opposite of the mode in Edit Properties, then Nav away or refresh and verify it goes back to what was in Edit Properties
- Go through original tests as well

…ce (#7529) Fix exporting from Limited Mode: #7268 (comment) Fix UI issues: #7268 (comment) Apply configuration changes made in Edit Properties. --------- Co-authored-by: Jesse Mazzella <[email protected]> Co-authored-by: Andrew Henry <[email protected]>

shefalijoshi · 2024-03-14T22:06:34Z

Existing telemetry tables are not using performance mode. They're using unlimited mode.
Error while saving properties via Edit properties dialog.
Set the Persist Data Mode toggle to off, save. Then reload the page. Now click Edit Properties, do the following at the same time in the dialog - Change the Data mode dropdown, toggle the persist data mode to ON) and save. This doesn't work and the Data Mode setting reverts to what it was previously and doesn't persist.
Also, noticed this console error while saving changes to table properties
openmct.js:2 TypeError: Cannot read properties of undefined (reading 'toString') at Object.unsubscribe (openmct-yamcs.js:1:17241) at of.<anonymous> (openmct.js:2:3047277) at $m.destroy (openmct.js:2:3033914) at lI.removeTelemetryCollection (openmct.js:2:4209443) at lI.addTelemetryObject (openmct.js:2:4204604) at openmct.js:2:4207563 at Array.forEach (<anonymous>) at lI.clearAndResubscribe (openmct.js:2:4207545) at lI.updateTelemetryMode (openmct.js:2:4203500) at Proxy.handleConfigurationChanges (openmct.js:2:4177157)

jvigliotta · 2024-03-15T19:26:04Z

Testing

More testing is above comment: #7268 (comment)

Make sure none of that is true anymore.

akhenry · 2024-03-20T21:37:16Z

Verified fixed

Open MCT Version	Memory	CPU
3.2.0	222MB	50.2
4.0.0	117	4.2

akhenry added the type:enhancement label Dec 1, 2023

akhenry assigned jvigliotta Dec 1, 2023

akhenry mentioned this issue Dec 1, 2023

Improve telemetry table performance akhenry/openmct-yamcs#400

Closed

jvigliotta mentioned this issue Jan 19, 2024

Table CPU Performance Improvements #7392

Merged

15 tasks

unlikelyzero added this to the Target:4.0.0 milestone Jan 22, 2024

jvigliotta mentioned this issue Jan 23, 2024

Table performance paging #7399

Merged

15 tasks

charlesh88 added a commit that referenced this issue Jan 24, 2024

Closes #7268

d9629db

- Layout and style sanding and polishing. - Added title to button. - More direct button labeling.

charlesh88 added a commit that referenced this issue Jan 24, 2024

Closes #7268

6fbdf7f

Partially closes #7147 - Removed footer hover behavior: table footer now always visible. - Tweaks to style, margin etc. to make footer more compact.

unlikelyzero closed this as completed in #7392 Jan 26, 2024

unlikelyzero added type:feature Feature. Required intentional design notable_change A change which should be noted in the changelog and removed type:enhancement labels Jan 26, 2024

unlikelyzero unassigned jvigliotta Jan 26, 2024

unlikelyzero mentioned this issue Feb 2, 2024

Real-time scrolling table views v2 #7147

Open

jvigliotta reopened this Feb 23, 2024

jvigliotta mentioned this issue Feb 28, 2024

[Telemetry Table] Address issues found during testing Table Performance #7529

Merged

15 tasks

akhenry closed this as completed in #7529 Mar 13, 2024

jvigliotta reopened this Mar 15, 2024

jvigliotta mentioned this issue Mar 15, 2024

[Telemetry Table] Telemetry mode bug fixes #7601

Merged

14 tasks

akhenry removed this from the Target:4.0.0 milestone Mar 18, 2024

jvigliotta added this to the Target:4.0.0 milestone Mar 18, 2024

akhenry added the severity:critical label Mar 18, 2024

jvigliotta closed this as completed in #7601 Mar 19, 2024

akhenry assigned shefalijoshi Mar 19, 2024

unlikelyzero unassigned shefalijoshi Mar 20, 2024

akhenry self-assigned this Mar 20, 2024

unlikelyzero unassigned akhenry Mar 27, 2024

unlikelyzero added the verified Tested or intentionally closed label Mar 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve telemetry table performance #7268

Improve telemetry table performance #7268

akhenry commented Dec 1, 2023 •

edited by jvigliotta

Loading

charlesh88 commented Jan 4, 2024 •

edited

Loading

jvigliotta commented Jan 23, 2024 •

edited by rukmini-bose

Loading

rukmini-bose commented Feb 8, 2024

charlesh88 commented Feb 8, 2024 •

edited

Loading

jvigliotta commented Feb 28, 2024

shefalijoshi commented Mar 14, 2024 •

edited by jvigliotta

Loading

jvigliotta commented Mar 15, 2024

akhenry commented Mar 20, 2024

Improve telemetry table performance #7268

Improve telemetry table performance #7268

Comments

akhenry commented Dec 1, 2023 • edited by jvigliotta Loading

charlesh88 commented Jan 4, 2024 • edited Loading

jvigliotta commented Jan 23, 2024 • edited by rukmini-bose Loading

Testing

CPU Performance

Memory/Paging/Mode Performance

Also

rukmini-bose commented Feb 8, 2024

charlesh88 commented Feb 8, 2024 • edited Loading

jvigliotta commented Feb 28, 2024

More Testing!

shefalijoshi commented Mar 14, 2024 • edited by jvigliotta Loading

jvigliotta commented Mar 15, 2024

Testing

akhenry commented Mar 20, 2024

akhenry commented Dec 1, 2023 •

edited by jvigliotta

Loading

charlesh88 commented Jan 4, 2024 •

edited

Loading

jvigliotta commented Jan 23, 2024 •

edited by rukmini-bose

Loading

charlesh88 commented Feb 8, 2024 •

edited

Loading

shefalijoshi commented Mar 14, 2024 •

edited by jvigliotta

Loading