Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting time conductor without changes causes downstream side-effects #7616

Open
2 of 7 tasks
shefalijoshi opened this issue Mar 18, 2024 · 1 comment
Open
2 of 7 tasks

Comments

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Mar 18, 2024

Submit button for the time conductor popup should not trigger network requests if there are no changes made to the modes/time ranges.

Summary

Closing the time conductor popup using the submit button with no changes causes downstream side-effects (like network requests).
Ideally the submit button should perform a noop (or something similar) if there are no changes to submit.

Expected vs Current Behavior

Pressing the submit button in the time conductor popup with no changes has downstream side effects.
Work around is to press the X (close time popup) button instead.

Steps to Reproduce

  1. Load Open MCT with realtime and fixed time modes configured
  2. Change the mode from realtime to fixed time (or vice-versa) and observe that network requests are triggered to receive new data for the new settings.
  3. Now press the submit button in the pop up
image 4. Notice that network requests are triggered again to receive new data.

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@unlikelyzero unlikelyzero changed the title Optimize time conductor submit button Submitting time conductor without changes causes downstream side-effects Apr 16, 2024
@unlikelyzero unlikelyzero added this to the Target:4.0.1 milestone Apr 16, 2024
@akhenry
Copy link
Contributor

akhenry commented Sep 27, 2024

Related, when using the remote clock, changing from realtime to fixed causes an immediate network request, before the changes are even submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants