Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this is 2024. * observers no more. #7715

Merged
merged 19 commits into from
May 9, 2024
Merged

this is 2024. * observers no more. #7715

merged 19 commits into from
May 9, 2024

Conversation

davetsay
Copy link
Contributor

@davetsay davetsay commented May 6, 2024 •
edited by ozyx
Loading

Closes #7710

Describe your changes:

Removed the * observer since the mutable domain object doesn't need it

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.50%. Comparing base (a69e300) to head (b282265).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7715      +/-   ##
==========================================
+ Coverage   56.38%   56.50%   +0.11%     
==========================================
  Files         673      673              
  Lines       27185    27181       -4     
  Branches     2635     2635              
==========================================
+ Hits        15329    15359      +30     
+ Misses      11526    11492      -34     
  Partials      330      330
Flag Coverage Δ
e2e-full 23.56% <ø> (+<0.01%) ⬆️
e2e-stable 60.38% <ø> (+0.44%) ⬆️
unit 49.21% <ø> (-0.02%) ⬇️
Files Coverage Δ
src/plugins/condition/ConditionManager.js 86.00% <ø> (+12.96%) ⬆️
...ugins/condition/components/ConditionCollection.vue 0.00% <ø> (ø)
src/plugins/condition/components/ConditionItem.vue 0.00% <ø> (ø)
src/plugins/condition/components/ConditionSet.vue 0.00% <ø> (ø)
src/plugins/condition/components/TestData.vue 0.00% <ø> (ø)

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a69e300...b282265. Read the comment docs.

@davetsay davetsay marked this pull request as ready for review May 8, 2024 23:47
ozyx
ozyx suggested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. I've left some suggestions for improving test locators and labels

e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js Outdated Show resolved Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js Outdated Show resolved Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js Outdated Show resolved Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js Outdated Show resolved Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js Outdated Show resolved Hide resolved
src/plugins/condition/components/ConditionItem.vue Outdated Show resolved Hide resolved
src/plugins/condition/components/ConditionSet.vue Outdated Show resolved Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js Outdated Show resolved Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js Outdated Show resolved Hide resolved
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js Outdated Show resolved Hide resolved
davetsay and others added 8 commits May 9, 2024 09:03
@davetsay davetsay requested a review from ozyx May 9, 2024 16:12
@ozyx ozyx added this to the Target:4.0.0 milestone May 9, 2024
@ozyx ozyx added the type:bug label May 9, 2024
ozyx
ozyx approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work

@davetsay davetsay added the pr:e2e:couchdb npm run test:e2e:couchdb label May 9, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label May 9, 2024
@davetsay davetsay added the pr:e2e:couchdb npm run test:e2e:couchdb label May 9, 2024
@davetsay davetsay removed the pr:e2e:couchdb npm run test:e2e:couchdb label May 9, 2024
@ozyx ozyx merged commit 977792f into master May 9, 2024
22 checks passed
@ozyx ozyx deleted the fix/7710-condition-set-composition branch May 9, 2024 18:19
@unlikelyzero unlikelyzero requested review from ozyx and removed request for ozyx August 6, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozyx ozyx ozyx approved these changes

Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging this pull request may close these issues.

Condition Sets don't allow removal from their composition
3 participants
@davetsay @codecov-commenter @ozyx