Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Telemetry Tables] e2e Test to make sure changing sort order in limited mode makes another request #488

Merged
merged 7 commits into from
Nov 5, 2024
Merged

[Telemetry Tables] e2e Test to make sure changing sort order in limited mode makes another request #488

merged 7 commits into from
Nov 5, 2024

Conversation

jvigliotta
Copy link
Collaborator

Closes

Describe your changes:

Add test to make sure changing sort order in limited mode triggers a another request for telemetry.

Covers this change: nasa/openmct#7875
Closes: nasa/openmct#7876

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

unlikelyzero
unlikelyzero reviewed Nov 1, 2024
View reviewed changes
tests/e2e/yamcs/telemetryTables.e2e.spec.mjs Outdated
const eventRequestOrderDescending = page.waitForRequest(/.*\/api\/.*\/events.*order=desc$/);

// Navigate to the Events table
await page.getByLabel('Navigate to Events yamcs.').click();
Copy link
Collaborator

@unlikelyzero unlikelyzero Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works, but the following would be better

await page.goto(./events, { waitUntil: 'networkidle' })

unlikelyzero
unlikelyzero approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Alternative suggestion in place

@unlikelyzero unlikelyzero added this to the Target:4.1.0 milestone Nov 1, 2024
@unlikelyzero unlikelyzero merged commit 4dbc009 into master Nov 5, 2024
9 checks passed
@unlikelyzero unlikelyzero deleted the mct-7876 branch November 5, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unlikelyzero unlikelyzero unlikelyzero approved these changes

Assignees
No one assigned
Labels
pr:e2e:quickstart
Projects
None yet
Milestone
Target:4.1.0
Development

Successfully merging this pull request may close these issues.

Test for sort fixes
2 participants
@jvigliotta @unlikelyzero