Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7899 fix srp for assignment #7910

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

WavesJ99
Copy link

@WavesJ99 WavesJ99 commented Oct 21, 2024

Closes #7899

Describe your changes: I am working on a team and trying to contribute to this project. This first contribution is supposed to be small and get us used to creating a pr. The change basically decouples the selection.js module with the DOM manipulation. This also makes selction.js adhere to SRP. We understand this is not a significant change but that is exactly what we we were looking for because of the description of our assignment.

All Submissions:

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 65.95745% with 16 lines in your changes missing coverage. Please review.

Project coverage is 54.63%. Comparing base (3241e9b) to head (2661965).

Files with missing lines Patch % Lines
src/selection/Selection.js 65.95% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7910      +/-   ##
==========================================
- Coverage   57.60%   54.63%   -2.98%     
==========================================
  Files         677      677              
  Lines       27373    27385      +12     
  Branches     2689     2689              
==========================================
- Hits        15768    14961     -807     
- Misses      11264    12083     +819     
  Partials      341      341              
Flag Coverage Δ *Carryforward flag
e2e-ci ?
e2e-full 53.85% <ø> (-0.06%) ⬇️ Carriedforward from 3241e9b
unit 49.26% <65.95%> (-0.06%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/selection/Selection.js 68.67% <65.95%> (-22.88%) ⬇️

... and 89 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3241e9b...2661965. Read the comment docs.

@ozyx ozyx added source:community Community contribution or request type:enhancement labels Oct 21, 2024
@ozyx ozyx self-requested a review October 21, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source:community Community contribution or request type:enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix-domManipulator
2 participants