Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gauge Plugin] Fix Missing Object handling #7923

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Gauge Plugin] Fix Missing Object handling #7923

wants to merge 4 commits into from

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Nov 5, 2024 •
edited
Loading

Closes #7908

Describe your changes:

Don't make requests if there's no metadata.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.13%. Comparing base (ea9947c) to head (2ef6354).

Files with missing lines Patch % Lines
src/plugins/gauge/components/GaugeComponent.vue 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7923      +/-   ##
==========================================
- Coverage   57.66%   57.13%   -0.53%     
==========================================
  Files         677      677              
  Lines       27373    27375       +2     
  Branches     2689     2690       +1     
==========================================
- Hits        15784    15641     -143     
- Misses      11250    11393     +143     
- Partials      339      341       +2
Flag Coverage Δ
e2e-ci 62.48% <ø> (+<0.01%) ⬆️
e2e-full 23.46% <ø> (-34.68%) ⬇️
unit 49.30% <0.00%> (-0.06%) ⬇️
Files with missing lines Coverage Δ
src/plugins/gauge/components/GaugeComponent.vue 62.35% <0.00%> (-1.85%) ⬇️

... and 15 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea9947c...2ef6354. Read the comment docs.

---- 🚨 Try these New Features:

@davetsay
Copy link
Contributor

davetsay commented Nov 7, 2024

Should we use telemetry collection here for gauges?

@jvigliotta
Copy link
Contributor Author

Should we use telemetry collection here for gauges?

Yes, but not for this one!

@jvigliotta jvigliotta requested review from charlesh88 and davetsay and removed request for charlesh88 November 18, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davetsay davetsay Awaiting requested review from davetsay

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gauges do not handle missing objects
2 participants
@jvigliotta @davetsay