Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and integrate open124 #134

Merged
merged 1 commit into from
Sep 18, 2015
Merged

Review and integrate open124 #134

merged 1 commit into from
Sep 18, 2015

Conversation

charlesh88
Copy link
Contributor

open #124
Removed "Default view" and "Display title by default" from
Panel configs;

Author checklist:

  • Changes address original issue? Y
  • Unit tests included and/or updated with changes? N/A
  • Command line build passes? N/A
  • Expect to pass code review? Y

@charlesh88
[Config] Removed non-functional config options from Create dialogs;
65368ed 
open #124
Removed "Default view" and "Display title by default" from
Panel configs;
@VWoeltjen
Copy link
Contributor

Reviewer Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? N/A (changes are to configuration, not code)
  3. Code style and in-line documentation are appropriate? N/A
  4. Commit messages meet standards? Y

VWoeltjen added a commit that referenced this pull request Sep 18, 2015
@VWoeltjen
Merge pull request #134 from nasa/open124
ad55251 
Review and integrate open124
@VWoeltjen VWoeltjen merged commit ad55251 into master Sep 18, 2015
@larkin larkin deleted the open124 branch October 9, 2015 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VWoeltjen VWoeltjen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesh88 @VWoeltjen