-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review and integrate open190: new .loading CSS class #191
Conversation
open #190 CSS for revised .loading class; Commented out/removed old .loading styles; Theme constants for loading colors added to theme files;
@charlesh88 do we have a place for style docs like this? Thinking of an analogue to the bootstrap docs, something that shows usage of css and html and serves as documentation of it. |
@@ -227,7 +227,8 @@ | |||
|
|||
.load-icon { | |||
position: relative; | |||
&.loading { | |||
|
|||
/* &.loading { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of commenting out, can we just remove this? Git history will allow it to be recovered if we need it later.
@charlesh88 Instead of commenting out unused scss, can you remove it instead? It can be restored from git history if we need it at a later date. |
open #190 Removed old .loading styles previously commented out;
Per suggestion, removed classes previously commented out and pushed to github. |
HTML/CSS usage is documented in the Style Guide, toward the end: https://drive.google.com/a/nasa.gov/file/d/0B0v27OM1JkSeRTg0bzE1Q0hDOEE/view?usp=sharing That said, this doc definitely needs to be updated and I'll add a task for this in the current sprint. |
Review Checklist
Integration Checklist
|
open #190
CSS for revised .loading class;
Commented out/removed old .loading styles;
Theme constants for loading colors added to theme files;
See notes in #190 for usage.
Author checklist: