Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and integrate open232 #236

Merged
merged 2 commits into from
Nov 4, 2015
Merged

Review and integrate open232 #236

merged 2 commits into from
Nov 4, 2015

Conversation

charlesh88
Copy link
Contributor

Updated SASS and re-rendered .css files.

Author checklist:

  • Changes address original issue? Y
  • Unit tests included and/or updated with changes? Y
  • Command line build passes? Unsure, no Maven installed
  • Expect to pass code review? Y

Resolve CSS conflicts for #236

Conflicts:
	platform/commonUI/general/res/sass/controls/_controls.scss
	platform/commonUI/themes/espresso/res/css/theme-espresso.css
	platform/commonUI/themes/snow/res/css/theme-snow.css
@VWoeltjen
Copy link
Contributor

Resolved conflicts and verified build success from command line

Reviewer Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? N/A (changes to stylesheets only)
  3. Code style and in-line documentation are appropriate? Y
  4. Commit messages meet standards? Y

VWoeltjen added a commit that referenced this pull request Nov 4, 2015
Review and integrate open232
@VWoeltjen VWoeltjen merged commit 2815d97 into master Nov 4, 2015
@VWoeltjen VWoeltjen deleted the open232 branch November 4, 2015 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants