Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and integrate open244 #248

Merged
merged 5 commits into from
Nov 6, 2015
Merged

Review and integrate open244 #248

merged 5 commits into from
Nov 6, 2015

Conversation

charlesh88
Copy link
Contributor

Multiple fixes related to the Inspector:

Author checklist:

  • Changes address original issue? Y
  • Unit tests included and/or updated with changes? N/A
  • Command line build passes? N/A
  • Expect to pass code review? Y

open #244
Fixing scroll issue in Inspector via flex layout;
Added new _archetypes.scss file for .l-flex* and .col styles;
moved .col and associated mixin out of _layout.scss
and into _archetypes;
open #244
Moved older .l-flex class out of layout and
into archetypes, updated definition;
open #243
Enlarged size of mini-tab icon when panes are collapsed;
Increased size of edge margin to allow for larger icons;
open #247
Modded styles applied to .object-browse-bar to
use overflow:hidden instead of visible;
@charlesh88 charlesh88 assigned charlesh88 and larkin and unassigned charlesh88 Nov 5, 2015
@charlesh88 charlesh88 added this to the Ballard milestone Nov 5, 2015
@larkin larkin merged commit e49b550 into master Nov 6, 2015
@larkin
Copy link
Contributor

larkin commented Nov 6, 2015

Review Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? N/A
  3. Code style and in-line documentation are appropriate? Y
  4. Commit messages meet standards? Y
  5. Project-specific information isolated to appropriate branches? Y

Integration Checklist

  1. Automated build passing after merge? Y
  2. No merge conflicts (or resolution trivial/obvious)? Y
  3. All master branches up-to-date after merge? Y
  4. Project-specific information isolated to appropriate branches? Y

@larkin larkin deleted the open244 branch November 6, 2015 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants