Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and integrate open251 #323

Merged
merged 1 commit into from
Nov 20, 2015
Merged

Review and integrate open251 #323

merged 1 commit into from
Nov 20, 2015

Conversation

charlesh88
Copy link
Contributor

#251

Fixed markup and CSS to remove erroneously
applied "select" class;
Modified .select to not use overflow: hidden;
Better positioning for *-options elements;

Author checklist:

  • Changes address original issue? Y
  • Unit tests included and/or updated with changes? N/A
  • Command line build passes? Sure
  • Expect to pass code review? Y

@charlesh88
[Frontend] Markup and CSS fixes
32815d8 
open #251
Fixed markup and CSS to remove erroneously
applied "select" class;
Modified .select to not use overflow: hidden;
Better positioning for *-options elements;
@charlesh88 charlesh88 added this to the Banks milestone Nov 20, 2015
@charlesh88 charlesh88 mentioned this pull request Nov 20, 2015
Closed
@charlesh88
Copy link
Contributor Author

Here's a screenshot:
screen shot 2015-11-19 at 6 54 33 pm

@akhenry
Copy link
Contributor

akhenry commented Nov 20, 2015

Looks good to me.

Reviewer Checklist

  • Changes appear to address issue? Y
  • Appropriate unit tests included? N/A
  • Code style and in-line documentation are appropriate? Y
  • Commit messages meet standards? Y

akhenry added a commit that referenced this pull request Nov 20, 2015
@akhenry
Merge pull request #323 from nasa/open251
fb0ba0c 
Review and integrate open251
@akhenry akhenry merged commit fb0ba0c into master Nov 20, 2015
@akhenry akhenry deleted the open251 branch November 20, 2015 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@akhenry akhenry

Labels
None yet
Projects
None yet
Milestone
Banks
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesh88 @akhenry