Review and integrate open169a #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $desktopMinW: 1281px; | ||
| $phoMaxW: 767px; | ||
| $tabMinW: 768px; | ||
| $tabMaxW: 1024px; |
There was a problem hiding this comment.
Previously the breakpoints were all contiguous. Now we have a no-man's land between tablet and desktop. Is this going to cause any problems?
|
Is possible this would be a problem - the no-mans land effectively becomes desktop, sort of. Let's leave this open for now, and I'll take another pass at it tomorrow. |
|
New branch and pull request: see #376. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open #169
[Frontend] Fixing bad breakpoints for tablet vs. desktop
Problem was the breakpoints. open169a da8fb99 changes desktop to enable at 1280 max-device-width; tablet is now 768 x 1024. This is a short-term fix: a laptop screen at 1024 max width will still have issues. This is the default resolution for a 13" Macbook. This will need a more comprehensive fix.
Author checklist: