Integrate styling for Search elements #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses WTD-1506 (context menu does not disappear after action is chosen); listen for click events on the menu itself and dismiss the menu when these occur.
Add listener to menu element directly instead of using ng-click to aid in testing (and for consistency with related listeners.) WTD-1506.
Remove unused dependency from generic search worker, avoids WTD-1511.
Remove unused dependency from generic search worker, avoids WTD-1511.
Bump version number and restore snapshot status to begin sprint Umbriel, WTD-825.
Original issue: https://github.jpl.nasa.gov/MissionControl/vista/issues/30 New CSS and symbols to support tabular views; Required by JPL branch vista30 (https://github.jpl.nasa.gov/MissionControl/vista/tree/vista30)
#70 Significant .scss and markup changes across search; New symbols font (v2.2) char for clear icon; To-do: style "load more" element;
|
Review Checklist
Integration Checklist
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and integrate these changes into the 'search' branch. As soon as this is complete, we should file a pull request to integrate the 'search' branch into open.
Author checklist: