Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Better sorting indicators added to styles #77

Merged
merged 1 commit into from
Aug 24, 2015
Merged

Conversation

charlesh88
Copy link
Contributor

https://github.jpl.nasa.gov/MissionControl/vista/issues/48
Simplified styles to indicate sort by asc and desc in table th elements;
(cherry picked from commit 15a2416)

Author checklist:

  • Changes address original issue? Y
  • Unit tests included and/or updated with changes? N/A
  • Command line build passes? N/A
  • Expect to pass code review? Y

Assumes that we'll add ng-click to all relevant th elements of the table. Add the following to the class attribute of the th of any table that's sortable:

  • Add "sort asc" or "sort desc" (depending on sort direction) when that column is controlling the sort order.
  • Add "sortable" to the th of any column that's clickable to control sort order. This displays the pointer cursor when the user hovers over the th. Don't add this to columns that can't control sorting.

Screenshot added of what the interface should look like in a VISTA datatable, sorting asc by "scet".
screen shot 2015-08-19 at 5 47 59 pm

JPL #48
Simplified styles to indicate sort by asc and desc in table th elements;
(cherry picked from commit 15a2416)
@larkin larkin merged commit 249a9b2 into master Aug 24, 2015
@larkin
Copy link
Contributor

larkin commented Aug 24, 2015

Review Checklist

Changes appear to address issue? Y
Appropriate unit tests included? (N/A - css only)
Code style and in-line documentation are appropriate? Y
Commit messages meet standards? Y
Project-specific information isolated to appropriate branches? Y

Integration Checklist

Automated build passing after merge? Y
No merge conflicts (or resolution trivial/obvious)? Y
All master branches up-to-date after merge? Y
Project-specific information isolated to appropriate branches? Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants