Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend conditional #7868

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
b4fdabf
adding telemetry collections to condition manager
jvigliotta Sep 12, 2024
5bd5ca9
handling telemetry collection data not datum
jvigliotta Sep 12, 2024
4ab19e3
adding from maaster
jvigliotta Sep 12, 2024
b467f9c
addressing PR comments
jvigliotta Sep 16, 2024
3f66140
Merge branch 'master' into conditional-style-performance
jvigliotta Sep 16, 2024
6482135
update unit test to work with telemetry collections
jvigliotta Sep 17, 2024
54c90e0
fixing tests
jvigliotta Sep 17, 2024
94a4ff3
removing unnecessary addition
jvigliotta Sep 17, 2024
7cba09b
removing focused describe
jvigliotta Sep 17, 2024
405b497
removing focused it
jvigliotta Sep 17, 2024
1581216
Merge branch 'master' into conditional-style-performance
jvigliotta Sep 17, 2024
5b385ea
fix weird test bleed
jvigliotta Sep 17, 2024
73489cd
Merge branch 'conditional-style-performance' of https://github.com/na…
jvigliotta Sep 17, 2024
23cf829
Add realtime output of telemetry data in conditionals and add support…
khalidadil Sep 19, 2024
21e94fd
Cleanup and add missing files
khalidadil Sep 21, 2024
101baa5
Fix issue with missing data
khalidadil Sep 30, 2024
7896f36
Update emitted values
khalidadil Sep 30, 2024
4b39ea2
Addressing feedback
khalidadil Sep 30, 2024
b975554
Creating a const for telemetry value
khalidadil Oct 1, 2024
7727a90
Cleanup
khalidadil Oct 1, 2024
f544a1d
Pass through plot options
khalidadil Oct 1, 2024
1180597
Cleanup
khalidadil Oct 2, 2024
39a73cf
Fix problem introduced with const
khalidadil Oct 3, 2024
0f2f71f
Add back initialize on mount
khalidadil Oct 3, 2024
4a3b0b9
Compensate for missing data at certain timestamps
khalidadil Oct 3, 2024
a739d61
Rename file
khalidadil Oct 3, 2024
488178a
Rename file
khalidadil Oct 3, 2024
f239d4b
Update metadata provider
khalidadil Oct 4, 2024
f4c2b79
Update condition set metadata
khalidadil Oct 11, 2024
bd3f00c
Fix zero issue
khalidadil Oct 11, 2024
cba2056
Try removing the default format for better data inspection
khalidadil Oct 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix weird test bleed
  • Loading branch information
jvigliotta committed Sep 17, 2024
commit 5b385ea7a65fadad7f6952608ca6add467c96681
22 changes: 11 additions & 11 deletions src/plugins/condition/pluginSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -769,17 +769,17 @@ describe('the plugin', function () {
await onAddCalledPromise;

// Simulate the passage of time and no data received
setTimeout(() => {
expect(mockListener).toHaveBeenCalledWith({
output: 'Any old telemetry',
id: {
namespace: '',
key: 'cf4456a9-296a-4e6b-b182-62ed29cd15b9'
},
conditionId: '39584410-cbf9-499e-96dc-76f27e69885d',
utc: undefined
});
}, 400);
await new Promise((resolve) => setTimeout(resolve, 400));

expect(mockListener).toHaveBeenCalledWith({
output: 'Any old telemetry',
id: {
namespace: '',
key: 'cf4456a9-296a-4e6b-b182-62ed29cd15b9'
},
conditionId: '39584410-cbf9-499e-96dc-76f27e69885d',
utc: undefined
});
});

it('should not evaluate as old when telemetry is received in the allotted time', async () => {
Expand Down