Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - more unit test freindly #30

Open
ksteinmetz opened this issue Oct 5, 2018 · 1 comment
Open

Suggestion - more unit test freindly #30

ksteinmetz opened this issue Oct 5, 2018 · 1 comment

Comments

@ksteinmetz
Copy link

Hi,
I happened on this great implementation while trying to get our code to talk to slack.
We had most of the basics in our own code, so this made sense.

While trying to unit test our code interface, I found phpunit can not mock your \Nexy\Slack\Client and \Nexy\Slack\Message classes, because they are marked Final.

It would be great if there was a simple interface that the Client and Message could implement so that your code can remain final and it is easy to mock your client and message classes through the interface. Then your code would be even more friendly.

Thanks and keep up the great work

@soullivaneuh
Copy link
Contributor

Hi @ksteinmetz and sorry for the long time for answer.

I like the idea, would you like to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants