Skip to content

Commit

Permalink
run tests with miniconda (fsspec#1658)
Browse files Browse the repository at this point in the history
  • Loading branch information
martindurant authored Aug 8, 2024
1 parent 8f29d95 commit 36cd82e
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 17 deletions.
19 changes: 6 additions & 13 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,15 @@ jobs:
fetch-depth: 0

- name: Setup conda
uses: mamba-org/setup-micromamba@v1
uses: conda-incubator/setup-miniconda@v3
with:
environment-file: ci/environment-py38.yml
create-args: >-
python=${{ matrix.PY }}
python-version: ${{ matrix.PY }}

- name: Run Tests
shell: bash -l {0}
run: |
pip install s3fs
pip uninstall s3fs
pip install -e .[test_full]
pip install s3fs --no-deps
pytest -v
win:
Expand All @@ -54,17 +50,14 @@ jobs:
fetch-depth: 0

- name: Setup conda
uses: mamba-org/setup-micromamba@v1
uses: conda-incubator/setup-miniconda@v3
with:
environment-file: ci/environment-win.yml

- name: Run Tests
shell: bash -l {0}
run: |
pip install s3fs
pip uninstall s3fs
pip install -e .[test]
pip install s3fs --no-deps
pytest -v
lint:
Expand All @@ -84,7 +77,7 @@ jobs:
# uses: actions/checkout@v4
#
# - name: Setup conda
# uses: mamba-org/setup-micromamba@v1
# uses: conda-incubator/setup-miniconda@v3
# with:
# environment-file: ci/environment-typecheck.yml
#
Expand All @@ -104,7 +97,7 @@ jobs:
fetch-depth: 0

- name: Setup conda
uses: mamba-org/setup-micromamba@v1
uses: conda-incubator/setup-miniconda@v3
with:
environment-file: ci/environment-downstream.yml

Expand Down Expand Up @@ -145,7 +138,7 @@ jobs:
uses: actions/checkout@v4

- name: Setup conda
uses: mamba-org/setup-micromamba@v1
uses: conda-incubator/setup-miniconda@v3
with:
environment-file: ci/environment-friends.yml

Expand Down
2 changes: 1 addition & 1 deletion ci/environment-downstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ name: test_env
channels:
- conda-forge
dependencies:
- python=3.9
- python=3.11
- pip:
- git+https://github.com/dask/dask
2 changes: 1 addition & 1 deletion ci/environment-friends.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: test_env
channels:
- conda-forge
dependencies:
- python=3.9
- python=3.12
- pytest
- pytest-asyncio !=0.22.0
- pytest-benchmark
Expand Down
1 change: 1 addition & 0 deletions ci/environment-py38.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ dependencies:
- pip
- git <2.45.0
- py
- s3fs
- pip:
- hadoop-test-cluster
- smbprotocol
4 changes: 3 additions & 1 deletion ci/environment-win.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@ name: test_env
channels:
- conda-forge
dependencies:
- python=3.9
- python=3.11
- s3fs
- pytest
2 changes: 1 addition & 1 deletion install_s3fs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ git clone https://github.com/fsspec/s3fs
mv s3fs ./downstream/s3fs

# s3fs is pinned to a specific version of fsspec
pip install -e ./downstream/s3fs # installs all deps, including latest released fsspec
pip install --no-input -e ./downstream/s3fs # installs all deps, including latest released fsspec

0 comments on commit 36cd82e

Please sign in to comment.