Skip to content

Commit d02886f

Browse files
authored
stability: Increase the number of retries on ec2_instance tests (ansible-collections#187)
* Split imports into a single line * Increase the max_attempts retries for the ec2_instance tests, we're running a *lot* in parallel which triggers RateLimiting errors
1 parent e93390a commit d02886f

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

Diff for: plugins/modules/ec2_instance.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -810,17 +810,17 @@
810810

811811
from ansible.module_utils.six import string_types
812812
from ansible.module_utils.six.moves.urllib import parse as urlparse
813+
from ansible.module_utils._text import to_bytes
813814
from ansible.module_utils._text import to_native
814-
import ansible_collections.amazon.aws.plugins.module_utils.ec2 as ec2_utils
815-
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import (AWSRetry,
816-
ansible_dict_to_boto3_filter_list,
817-
compare_aws_tags,
818-
boto3_tag_list_to_ansible_dict,
819-
ansible_dict_to_boto3_tag_list,
820-
camel_dict_to_snake_dict,
821-
)
822815

823816
from ansible_collections.amazon.aws.plugins.module_utils.core import AnsibleAWSModule
817+
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import AWSRetry
818+
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import ansible_dict_to_boto3_filter_list
819+
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import compare_aws_tags
820+
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import boto3_tag_list_to_ansible_dict
821+
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import ansible_dict_to_boto3_tag_list
822+
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import camel_dict_to_snake_dict
823+
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import snake_dict_to_camel_dict
824824

825825
module = None
826826

@@ -917,7 +917,7 @@ def build_volume_spec(params):
917917
for int_value in ['volume_size', 'iops']:
918918
if int_value in volume['ebs']:
919919
volume['ebs'][int_value] = int(volume['ebs'][int_value])
920-
return [ec2_utils.snake_dict_to_camel_dict(v, capitalize_first=True) for v in volumes]
920+
return [snake_dict_to_camel_dict(v, capitalize_first=True) for v in volumes]
921921

922922

923923
def add_or_update_instance_profile(instance, desired_profile_name):

Diff for: tests/integration/targets/ec2_instance/roles/ec2_instance/tasks/main.yml

+5
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@
2424
aws_secret_key: "{{ aws_secret_key }}"
2525
security_token: "{{ security_token | default(omit) }}"
2626
region: "{{ aws_region }}"
27+
aws_config:
28+
retries:
29+
# Unfortunately AWSRetry doesn't support paginators and boto3's paginators
30+
# don't support any configuration of the delay between retries.
31+
max_attempts: 20
2732
collections:
2833
- amazon.aws
2934
block:

0 commit comments

Comments
 (0)