Simplify VaryBatchSize mixin, remove unneeded self.batch_size #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvacaporale
reviewed
Nov 4, 2020
| batch_sizes = config.get("batch_sizes", None) | ||
| assert isinstance(batch_sizes, list), "Must specify list of batch sizes" | ||
| self.batch_sizes = batch_sizes | ||
| assert isinstance(batch_sizes, Sequence), "Must specify list of batch sizes" |
Contributor
There was a problem hiding this comment.
The comment should now read "Must specify a sequence of batch sizes"
Contributor
Author
There was a problem hiding this comment.
Ok, I can change it. (Often in code comments I use "list" in the generic English sense. Usually I rely on duck-typing rather than type checking -- as long as they pass in something that supports indexing and len, the code will work)
Contributor
There was a problem hiding this comment.
I see. That's fair. Either way.
| if 0 < self.current_epoch < len(self.batch_sizes): | ||
| batch_size = self.batch_sizes[self.current_epoch] | ||
| self.train_loader = self.create_train_dataloader( | ||
| {**self.config, "batch_size": batch_size} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on adding an interface that allows the VaryBatchSize mixin to adjust the
self.total_stepsproperty so that it is compatible with OneCycleLR. That change will be easier with this simplified VaryBatchSize code.Note that it's better to do
isinstance(v, Sequence)instead ofisinstance(v, list), because tuples should also be allowed.