-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node deprecation warning for Punycode #1445
Comments
Framework doesn’t use punycode directly. The line you linked to is a list of Node’s built-in packages and is used for resolving node imports. I traced the dependency to the psl library.
The dependency chain is: @observablehq/framework → jsdom@^23.2.0 → tough-cookie@^4.1.3 → psl@^1.1.33 This was fixed in lupomontero/psl#298, but a new version of psl has not been published in two years, so it’s unclear if this will be fixed anytime soon. This may also be fixed by tough-cookie in salesforce/tough-cookie#346, but it is waiting for a v5 release. It could also be fixed by JSDOM; see jsdom/jsdom#3613. At any rate, the problem is not within this library, unless we’re willing to drop the dependency on JSDOM (and we’re not currently). |
Node.js v22.2.0 documentation lists punycode as deprecated:
https://nodejs.org/api/punycode.html
However Framework uses this package:
framework/src/node.ts
Line 197 in e4682b3
When running commands, I continually encounter this warning:
It would be great if we could find a way to avoid seeing this warning.
The text was updated successfully, but these errors were encountered: