Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanUrls set to false do not change the home page link #1479

Closed
massyn opened this issue Jun 24, 2024 · 1 comment
Closed

cleanUrls set to false do not change the home page link #1479

massyn opened this issue Jun 24, 2024 · 1 comment
Labels
bug Something isn’t working

Comments

@massyn
Copy link

massyn commented Jun 24, 2024

When setting the observablehq.config.jq file with the cleanUrls option to False, per https://observablehq.com/framework/config#cleanurls.

The documentation states:

Whether page links should be “clean”, i.e., formatted without a .html extension. Defaults to true. If true, a link to config.html will be formatted as config. Regardless of this setting, a link to an index page will drop the implied index.html; for example foo/index.html will be formatted as foo/.

While deploying the dashboard on an AWS S3 bucket with CloudFront, the fact that the home page is not linked to index.html is causing an 404 error. The behaviour of cleanUrls will need to be updated so that when cleanUrls is set to False, it needs to render the foo/ link as foo/index.html to allow the web server to still serve the page, even when index.html is not the default page to be served.

@massyn massyn added the bug Something isn’t working label Jun 24, 2024
@mootari
Copy link
Member

mootari commented Jun 25, 2024

As far as I can tell that's working as designed. I suspect you need to configure an index document for your bucket: https://docs.aws.amazon.com/AmazonS3/latest/userguide/IndexDocumentSupport.html

@Fil Fil closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

No branches or pull requests

3 participants