Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use "weak " symbols on Windows #2215

Merged
merged 2 commits into from
Jul 9, 2023
Merged

Conversation

liux-pro
Copy link
Contributor

@liux-pro liux-pro commented Jul 2, 2023

Not only cygwin, all linker on windows like msvc, mingw, cygwin don't support weak.
#393

@liux-pro
Copy link
Contributor Author

liux-pro commented Jul 2, 2023

_WIN32 defined on Windows both 32 and 64 bit.

@olikraus olikraus merged commit 8bd0e39 into olikraus:master Jul 9, 2023
@olikraus olikraus added this to the 2.35 milestone Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants