Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make update-otel #6922

Merged
merged 8 commits into from
Dec 21, 2021
Merged

make update-otel #6922

merged 8 commits into from
Dec 21, 2021

Conversation

codeboten
Copy link
Contributor

Updated the collector dependency. This brought in two breaking changes:

  • removal of the in-memory config map provider
  • removal of the configauth interceptors.

Leaving this PR in draft until open-telemetry/opentelemetry-collector#4558 is merged and provides a decision on what to do w/ the oidc extension

@jpkrohling
Copy link
Member

jpkrohling commented Dec 21, 2021 •
edited
Loading

I just added a commit to this PR removing the interceptors from the OIDC tests.

@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 21, 2021
jpkrohling
jpkrohling approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the OIDC extension look good to me.

@jpkrohling jpkrohling mentioned this pull request Dec 21, 2021
Merged
@codeboten codeboten force-pushed the codeboten/make-update-otel-dec-20 branch from 75d1bce to 3f4abdc Compare December 21, 2021 16:35
@codeboten codeboten marked this pull request as ready for review December 21, 2021 16:36
@codeboten codeboten requested a review from a team December 21, 2021 16:36
@codeboten codeboten enabled auto-merge (squash) December 21, 2021 16:36
@codeboten codeboten force-pushed the codeboten/make-update-otel-dec-20 branch from e8956a7 to 002048d Compare December 21, 2021 19:03
@codeboten codeboten merged commit bc72335 into open-telemetry:main Dec 21, 2021
@codeboten codeboten deleted the codeboten/make-update-otel-dec-20 branch December 21, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

@alolita alolita Awaiting requested review from alolita

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@anuraaga anuraaga Awaiting requested review from anuraaga

@arminru arminru Awaiting requested review from arminru

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@owais owais Awaiting requested review from owais

@punya punya Awaiting requested review from punya

Assignees

@jpkrohling jpkrohling

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeboten @jpkrohling @bogdandrutu