Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert change to processortest.NopSettings name #11433

Closed
bogdandrutu opened this issue Oct 13, 2024 · 1 comment · Fixed by #12107
Closed

Revert change to processortest.NopSettings name #11433

bogdandrutu opened this issue Oct 13, 2024 · 1 comment · Fixed by #12107
Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@bogdandrutu
Copy link
Member

In #9637, we created a unique name per settings:

  1. This is inconsistent with other nop settings.
  2. The change is no longer needed because we no longer use prometheus server to test internal telemetry.
@bogdandrutu bogdandrutu added the help wanted Good issue for contributors to OpenTelemetry Service to pick up label Oct 13, 2024
@Tharanishwaran
Copy link

@bogdandrutu can i work on this issue ?

@zzzk1 zzzk1 mentioned this issue Jan 16, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2025
@zzzk1
[chore] Revert the change in processortest setting creation (#12107)
a3c7d95 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Revert the `nop_processor.NewNopSettings` change, as it is no longer
needed.
<!-- Issue number if applicable -->
#### Link to tracking issue
Fixes #11433


<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] Revert the change in processortest setting creation zzzk1/opentelemetry-collector
2 participants
@bogdandrutu @Tharanishwaran