Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pdata to proto 1.4.0 #11720

Closed
dmathieu opened this issue Nov 21, 2024 · 0 comments · Fixed by #11722
Closed

Upgrade pdata to proto 1.4.0 #11720

dmathieu opened this issue Nov 21, 2024 · 0 comments · Fixed by #11722
Assignees
Labels
area:pdata pdata module related issues

Comments

@dmathieu
Copy link
Member

Version 1.4.0 of opentelemetry-proto was released a few hours ago.
https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v1.4.0

We need to upgrade pdata to use that version.
Most of the changes in that version are profiles changes. Many of them are breaking (which is expected for an in-development signal).

@dmathieu dmathieu added the area:pdata pdata module related issues label Nov 21, 2024
@dmathieu dmathieu self-assigned this Nov 21, 2024
mx-psi added a commit that referenced this issue Nov 28, 2024
This upgrades pdata to the
[1.4.0](https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v1.4.0)
version of protobufs.

Sorry for the very large PR. This can't really be split into smaller PRs
though, as changes are not backwards compatible.

This PR includes
#11706, as
the two are very close and separating them would cause weird conflicts.
The two changes can be merged either as separate PRs (with 11706 first),
or as one.

Closes
#11720

cc @mx-psi

---------

Co-authored-by: Pablo Baeyens <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this issue Dec 19, 2024
This upgrades pdata to the
[1.4.0](https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v1.4.0)
version of protobufs.

Sorry for the very large PR. This can't really be split into smaller PRs
though, as changes are not backwards compatible.

This PR includes
open-telemetry#11706, as
the two are very close and separating them would cause weird conflicts.
The two changes can be merged either as separate PRs (with 11706 first),
or as one.

Closes
open-telemetry#11720

cc @mx-psi

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:pdata pdata module related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant