Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheduler): adding SpaceWeighted scheduler #178

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented Feb 25, 2022

fixes: #104

adding a new scheduler logic which selects the node
which has max free space available. This is better scheduling
algorithm than the volumeweighted and capacity weighted where we
don't check for the free space available on the node.

Release note
Making it a default scheduler, so, now onwards, for immediate binding case, the controller will pick the node which has largest free space available for provisioning the volumes.

Signed-off-by: Pawan [email protected]

adding a new scheduler logic which selects the node
which has max free space available. This is better scheduling
algorithm than the volumeweighted and capacity weighted where we
don't check for the free space available on the node.

Signed-off-by: Pawan <[email protected]>
Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pawanpraka1 Have a few nitpick comments

pkg/driver/schd_helper.go Outdated Show resolved Hide resolved
pkg/driver/schd_helper.go Show resolved Hide resolved
Signed-off-by: Pawan <[email protected]>
Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pawanpraka1
Copy link
Contributor Author

@w3aman please verify this feature.

wowditi pushed a commit to wowditi/lvm-localpv that referenced this pull request Apr 6, 2022
adding a new scheduler logic which selects the node
which has max free space available. This is better scheduling
algorithm than the volumeweighted and capacity weighted where we
don't check for the free space available on the node.

Signed-off-by: Pawan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LVM-LocalPV should pick the node where enough space is available for immediate binding
2 participants