[WIP] feat(shared-vg) : add support for create, delete, publish & unpublish of shared volumes#184
Closed
Ab-hishek wants to merge 3 commits into
Closed
[WIP] feat(shared-vg) : add support for create, delete, publish & unpublish of shared volumes#184Ab-hishek wants to merge 3 commits into
Ab-hishek wants to merge 3 commits into
Conversation
Signed-off-by: Abhishek Agarwal <abhishek.agarwal@mayadata.io>
pawanpraka1
reviewed
Apr 8, 2022
| if vol.Spec.SharedMode == apis.LVMExclusiveSharedMode { | ||
| // Deactivate the LV before sending a successful response | ||
| // lvchange -an <lv-name> | ||
| err = lvm.ActivateLVMLogicalVolume(vol, false) |
Contributor
There was a problem hiding this comment.
let us not use name ActivateLVMLogicalVolume when using it for deactivation. We can use function name as ChangeLVMVolume and pass the desired status in the argument.
Contributor
|
@Ab-hishek can you please add the details about how much testing has been done and what part needs to be tested yet. |
Member
|
The implementation of this change resulted in unknown and complex scenarios. It's been decided after consulting the original author of the PR, that we can close this PR. If any one is interested to continue the shared-vg feature development, please feel free to re-open and refer the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhishek Agarwal abhishek.agarwal@mayadata.io
Why is this PR required? What issue does it fix?:
This PR addresses the issue of adding support for creating volumes LVM2 shared volume groups.
What this PR does?:
Add new features for volumes on top of shared volume groups. This PR adds support for the following workflows:
NOTE:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Testing is yet to be done
Any additional information for your reviewer? :
Design doc for this PR: https://docs.google.com/document/d/1QJUPW3C8DSSwRkCjgh_O472KfZcgTnU9/edit?usp=sharing&ouid=106351714067742402436&rtpof=true&sd=true
Checklist:
<type>(<scope>): <subject>