Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller refactor to use dynamic client instead of generated code #189

Closed
3 of 4 tasks
abhilashshetty04 opened this issue Apr 25, 2022 · 1 comment
Closed
3 of 4 tasks
Assignees

Comments

@abhilashshetty04
Copy link
Contributor

abhilashshetty04 commented Apr 25, 2022

This project uses controllers which watches over 3 cr's. Controller plugin(lvmnodes). Node plugin(lvmvolumes, lvmnodes, lvmsnapshots)

Currently all these controllers are using generated code to implement client. We could use dynamic client from client-go which would reduce code foot prints and will make code more readable as well. In addition to that i am adding only 1 method which would create and return controllers as opposed to using multiple methods to build controller.

Progress on each controller:

Node plugin:

  • lvmvolumes : Refactored and tested. WIP pr is raised
  • lvmnodes : Refactored and tested. WIP pr is raised
  • lvmsnapshots: Refactored and tested. WIP pr is raised

Controller plugin:

  • lvmnodes : Yet to start

PR:
#186

@abhilashshetty04
Copy link
Contributor Author

Pr is merged. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant