Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ResourceList for capacity #2

Open
pawanpraka1 opened this issue Dec 31, 2020 · 3 comments
Open

use ResourceList for capacity #2

pawanpraka1 opened this issue Dec 31, 2020 · 3 comments
Labels
Backlog help wanted Extra attention is needed

Comments

@pawanpraka1
Copy link
Contributor

Describe the problem/challenge you have

Currently capacity is string. We should move towards ResourceList to store the capacity.

@pawanpraka1 pawanpraka1 changed the title use resource ResourceList for capacity use ResourceList for capacity Dec 31, 2020
@dsharma-dc
Copy link
Contributor

Unsure of reasons behind needing this. Checking if it's not something that will have side-effects or breaking behaviour.

@dsharma-dc
Copy link
Contributor

This pertains to changing the type of Capacity in VolumeInfo.

// VolumeInfo defines LVM info
type VolumeInfo struct {

[...]

	// Capacity of the volume
	// +kubebuilder:validation:Required
	// +kubebuilder:validation:MinLength=1
	Capacity string `json:"capacity"`

@dsharma-dc dsharma-dc added the help wanted Extra attention is needed label Jul 30, 2024
@avishnu
Copy link
Member

avishnu commented Sep 12, 2024

This needs to be consistent across all engines. Need to assess the impact of this modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants