Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the installation of snapshot.storage.k8s.io CRDs optional #203

Closed
phhutter opened this issue Jul 14, 2022 · 1 comment
Closed

make the installation of snapshot.storage.k8s.io CRDs optional #203

phhutter opened this issue Jul 14, 2022 · 1 comment

Comments

@phhutter
Copy link
Contributor

Hi,

Could we make the installation of the following CRDs optional?

https://github.com/openebs/lvm-localpv/blob/develop/deploy/helm/charts/crds/volumesnapshotclasses.yaml
https://github.com/openebs/lvm-localpv/blob/develop/deploy/helm/charts/crds/volumesnapshotcontents.yaml
https://github.com/openebs/lvm-localpv/blob/develop/deploy/helm/charts/crds/volumesnapshots.yaml

Is there a reason why you have included them in the openEBS helmchart? These resources are usually maintained and managed by the underlying kubernetes distribution. In case of OpenShift, it will automatically revert back the modifications made by your helmchart. This could be problematic if you use ArgoCD and have it on autosync.

@abhilashshetty04
Copy link
Contributor

Done in #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants