Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configurable polling interval in NodeController #255

Closed
omric-runai opened this issue Sep 3, 2023 · 0 comments · Fixed by #256
Closed

Allow configurable polling interval in NodeController #255

omric-runai opened this issue Sep 3, 2023 · 0 comments · Fixed by #256

Comments

@omric-runai
Copy link
Contributor

omric-runai commented Sep 3, 2023 •
edited
Loading

Describe the problem/challenge you have
Current polling interval in NodeController is hardcoded to be 60 seconds. This means that the latency for node updates, and in turn CSIStorageCapacity updates, is up to 60s, even after a PVC was bound. As a result, custom k8s schedulers that are aware of storage can make bad decisions - either unnecessary evictions, or impossible allocations.

Describe the solution you'd like
Make pollInterval in lvmnode.NodeController configurable, with the default being 60s like today, and allow users to customize according to their use-case.

Environment:

  • LVM Driver version: 1.2.0
  • Kubernetes version (use kubectl version): v1.27.4
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(NodeController): made node polling interval configurable omric-runai/lvm-localpv
1 participant
@omric-runai