Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid yaml in helm chart #269

Closed
maxs-rose opened this issue Nov 11, 2023 · 2 comments
Closed

Invalid yaml in helm chart #269

maxs-rose opened this issue Nov 11, 2023 · 2 comments

Comments

@maxs-rose
Copy link
Contributor

maxs-rose commented Nov 11, 2023

What steps did you take and what happened:

Synth yaml from cdk8s

See: cdk8s-team/cdk8s-core#1850

What did you expect to happen:

Synth to work

Anything else you would like to add:

This is due to invalid yaml in the helm chart and cdk8s using a spec ompliant yaml parser (https://github.com/eemeli/yaml).

Example can be seen here:

description: 'message is a string detailing the encountered error
during snapshot creation if specified. NOTE: message may be
logged, and it should not contain sensitive information.'

This needs to be indented by at least 1 space otherwise each new line of the description should be treated as a new implicit key.

properties:
  message:
    description: 'message is a string detailing the encountered error
     during snapshot creation if specified. NOTE: message may be
     logged, and it should not contain sensitive information.'
    type: string

Would be valid for example

Environment:

  • LVM Driver version: N/A
  • Kubernetes version (use kubectl version): N/A
  • Kubernetes installer & version: N/A
  • Cloud provider or hardware configuration: N/A
  • OS (e.g. from /etc/os-release): N/A
@maxs-rose
Copy link
Contributor Author

I would be happy to make a MR to fix this

@Abhinandan-Purkait
Copy link
Member

Has been included in #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants