fix(charts): Corrected invalid YAML in description tags #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some description tags had an invalid structure for multi line strings. For Example: ```yaml description: 'Some description` ``` Multi line single quoted flows require at least 1 level of indentation or else a parser should treat the first word on the new line as an implicit key. Valid example: ```yaml description: 'Some description' ``` Signed-off-by: Max Rose <[email protected]>
Signed-off-by: Max Rose <[email protected]>
Abhinandan-Purkait
approved these changes
Nov 17, 2023
abhilashshetty04
approved these changes
Nov 21, 2023
|
@maxs-rose , Thanks for your contribution. Since you have done chart version bump we will cherry pick this into new PR. |
6 tasks
|
Included in #277 |
|
Those CRDs are sourced from kubernetes-sigs/external-snapshotter. Those CRDs are generated using kube-builder's controller-gen tool. If you'd like to address this issue at its core, that's where you'd want look. This doesn't affect the lvm-localpv installers (yamls) in any way, these yamls are meant to satify kubernetes' API validation, external linter criteria are a non-goal. cc: @avishnu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
Some description tags had an invalid structure for multi line strings. For Example:
Multi line single quoted flows require at least 1 level of indentation or else a parser should treat the first word on the new line as an implicit key.
Valid example:
What this PR does?:
Correct invalid yaml for multi line descriptions
Does this PR require any upgrade changes?: No
Checklist:
<type>(<scope>): <subject>